fix: convert last checkpoint json keys to camelCase #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feniljain
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
+ Coverage 72.37% 72.41% +0.04%
==========================================
Files 133 133
Lines 40238 40253 +15
Branches 40238 40253 +15
==========================================
+ Hits 29124 29151 +27
+ Misses 9239 9237 -2
+ Partials 1875 1865 -10 ☔ View full report in Codecov by Sentry. |
|
@feniljain can you add a test? |
|
Hey, I have added a small test. It's hacky, and I am not sure if you are looking for a different type of test. If yes, do help me out by pointing me to it 😅 |
ion-elgreco
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While storing
_last_checkpointdelta-rs does not convert json keys to camel case, but protocol mentions they should be in camelCase, fix exactly that :)Related Issue(s)
Fixes delta-incubator/delta-kernel-rs#326
Documentation
Issue description is nicely documented :)
Output screenshots:
Tested with local crate copy and created a table